Repository navigation
Release/705 Engineblock 7.3 - #777
Open
baszoetekouw wants to merge 6 commits into
Open
baszoetekouw wants to merge 6 commits into
baszoetekouw wants to merge 6 commits into
Conversation
baszoetekouw
force-pushed
the
release/705
branch
from
November 6, 2026 14:44
b2c7c74 to
60e03d5
Compare
pmeulen
approved these changes
Nov 10, 2026
| feature_enable_sram_interrupt: {{ engine_feature_enable_sbs_interrupt | bool | to_json }} | ||
| feature_hide_bookmarkable_url: {{ engine_feature_hide_bookmarkable_url | bool | to_json }} | ||
| # TODO: feature flag is misnamed. The remember-my-choice is configurable for individual _SPs_ | ||
| feature_enable_wayf_remember_choice_per_idp: {{ engine_wayf_show_remember_choice_per_sp | bool | to_json }} |
Member
There was a problem hiding this comment.
Needs to be fixed in EB. But if you don't fix it now, will you ever fix it?
Consider fixing the feature_enable_wayf_remember_choice_per_idp flag in EB, then releasing.
Member
Author
There was a problem hiding this comment.
makes sense, and easy to fix in EB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.